refactor(ui): replace the installed-extension tag cloud with a compact Composer namespace ledger. - #28
Conversation
…t Composer namespace ledger.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #28 +/- ##
============================================
Coverage 100.00% 100.00%
- Complexity 1724 1744 +20
============================================
Files 141 141
Lines 6774 7065 +291
============================================
+ Hits 6774 7065 +291 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Warning Review limit reachedNext included review available in 49 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (10)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (4)
🧰 Additional context used🪛 PHPMD (2.15.0)tests/View/Sidebar/SidebarRendererTest.php[warning] 19-421: The class SidebarRendererTest has 12 public methods. Consider refactoring SidebarRendererTest to keep number of public methods under 10. (undefined) (TooManyPublicMethods) tests/Toolbar/ToolbarDataTest.php[error] 21-21: Avoid using static access to class '\PHPForge\Debug\Toolbar\ToolbarData' in method 'testCreateAndWithersBuildAnImmutablePayload'. (undefined) (StaticAccess) tests/Panel/Config/ConfigCardRendererTest.php[warning] 17-402: The class ConfigCardRendererTest has 12 public methods. Consider refactoring ConfigCardRendererTest to keep number of public methods under 10. (undefined) (TooManyPublicMethods) tests/Storage/RequestSummaryTest.php[error] 19-19: Avoid using static access to class '\PHPForge\Debug\Storage\RequestSummary' in method 'testCreateAndWithersBuildAnImmutableSummary'. (undefined) (StaticAccess) src/Storage/RequestSummary.php[warning] 157-157: Avoid excessively long variable names like $excessiveCallersCount. Keep variable name length under 20. (undefined) (LongVariable) [error] 230-230: The method withRequest has a boolean flag argument $ajax, which is a certain sign of a Single Responsibility Principle violation. (undefined) (BooleanArgumentFlag) [warning] 230-230: Avoid variables with short names like $ip. Configured minimum length is 3. (undefined) (ShortVariable) src/View/Sidebar/SidebarSnapshot.php[error] 124-124: The method withCursor has a boolean flag argument $isCursor, which is a certain sign of a Single Responsibility Principle violation. (undefined) (BooleanArgumentFlag) [error] 217-217: The method withRequest has a boolean flag argument $isAjax, which is a certain sign of a Single Responsibility Principle violation. (undefined) (BooleanArgumentFlag) src/Panel/Config/ConfigCardRenderer.php[error] 26-347: The class ConfigCardRenderer has a coupling between objects value of 16. Consider to reduce the number of dependencies under 13. (undefined) (CouplingBetweenObjects) 🔇 Additional comments (15)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe change replaces the installed-extension tag cloud with a vendor-grouped Composer package ledger. It also adds immutable factory and enrichment methods to request, toolbar, and sidebar data classes, with tests for the new APIs. ChangesComposer package ledger
Immutable data builders
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to The PR reorganizes debug UI presentation and adds immutable data builders without introducing a concrete production or user-facing hazard; no actionable merge-blocking risk remains after normal checks and review. Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 75.76% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 33 functions across 8 files. (2 skipped: 2 unsupported.) ✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Pull Request