phpstan: Check tests - #24
Merged
Merged
Conversation
We do not ignore any errors. And it is better to specify it for individual errors with custom explanation for each. If we introduce baseline, it should only contain universal errors. https://phpstan.org/user-guide/baseline
This will make it easier to notice discrepancies. Had to add some ignores to suppress errors from differences between versions.
Contributor
|
yep, tests should also be sane. if you want to work on the issues reported by phpstan, happy to review pull requests. meanwhile i merge this. we should also fix the lowest version build eventually, its a sign some minimum requirement is not accurate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Add tests directory to list ouf sources checked by PHPStan.
Why?
This will make it easier to notice discrepancies.