Repository navigation
ci: install libbrotli-dev instead of reinstalling it - #2723
Merged
Merged
Conversation
dunglas
marked this pull request as ready for review
October 16, 2026 12:20
alexandre-daubois
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2391 added
apt-get install --reinstall -y libbrotli-devbecause the ubuntu-24.04 image listedlibbrotli-devas installed while its headers and.pcfiles were missing, which turned a plain install into a no-op.That state is gone. The latest
mainrun (image 20261004.327.1, https://github.com/php/frankenphp/actions/runs/38149908385) showsThe following NEW packages will be installed: libbrotli-dev: the image no longer ships the package at all, only thebrotliCLI (see the image readme). Nothing will be fixed upstream, so the step stays, as a regular install, and the TODO goes away.