Repository navigation
Conversation
dunglas
marked this pull request as ready for review
October 16, 2026 21:59
henderkes
approved these changes
Oct 18, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tests/shutdown_test.sh(added in #2645) failed on #2721 withFAIL: PHP request failed with curl exit code 55(job). The failure lines up with the last server log line,servers shutting down; grace period initiated, logged when Caddy closes its listeners aftershutdown_delay.Closing a listening socket resets the connections still waiting in its accept queue. Depending on when the reset reaches curl, the request fails with 52 (empty reply), 56 (receive error) or 55 (send error). The test already treated 52 and 56 as
closing, but not 55, which needs the reset to arrive betweenconnect()and the firstsend().Stressing the shutdown in a Linux container (40 restarts, 24 concurrent clients, ~36k requests against
main) produced 29 脳 52 and 30 脳 56 at listener close and no other errors, so 55 is the same race with a narrower window. The server can't prevent it, so the test now accepts 55 too. The checks that matter are unchanged: requests served duringshutdown_delay, in-flight requests drained, PHP shut down last. The patched script passed 10/10 runs in the same container.