Repository navigation
Conversation
The nightly run skipped a variant whenever its base images matched the versioned builder tag. If a scheduled run went out while a release was still a draft, the floating major tags were pushed back to the previous release. Nothing moved them forward again until a base image changed, which left 1-php8.4-alpine on 1.13.0 after 1.13.1 was published. Also require the floating major builder tag to carry the latest release version before skipping a variant.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2710, cc @dunglas @AlliBalliBaba.
The nightly run skips a variant when its base images match the fingerprint on the versioned builder tag. When the scheduled run on 11 October went out while v1.13.1 was still a draft, it rebuilt v1.13.0 and pushed the floating major tags back to it. After the release was published, the Debian bases had changed, so those variants were rebuilt and their floating tags moved forward. The Alpine bases had not, so Alpine was skipped and the floating Alpine tags are still on v1.13.0.
Current state on Docker Hub:
org.opencontainers.image.version1.13.1-builder-php8.4-alpine9fb1ee49dd1c1-builder-php8.4-alpine9fb1ee49dd1c1-builder-php8.4-trixieb5ec56f7d93fThis PR adds one more condition before skipping a variant: the floating major builder tag must already carry the latest release version. On a normal night nothing changes, because the floating tag is already on the latest release. After a release like this one, the stale variants get rebuilt and their floating tags repointed.
Checked with
bash -nandshellcheck. If you would rather not change the workflow, feel free to close this; a manual run of the Docker workflow onv1.13.1would fix the current tags.