ci: run the whole test suite - #11
Open
somethingwithproof wants to merge 2 commits into
Open
Conversation
Without tests/data the SKIPIF blocks skip 16 of the 22 tests, so CI reported green while most of the suite never ran. Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Both were written against an older librrd and fail against 1.7.2 and 1.11.0 alike; they were never noticed because the fixtures were missing. Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
somethingwithproof
force-pushed
the
ci/run-full-test-suite
branch
from
August 21, 2026 04:26
3e3d32c to
109a553
Compare
This was referenced Aug 21, 2026
Contributor
Author
|
@remicollet Thanks for the context on #18. I have split the follow-up work into a linear stack so each concern can be reviewed separately:\n\n#11 → #12 → #13 → #14 → #15 → #16 → #17 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
16 of the 22 tests are gated on fixtures under
tests/data/that nothing ever builds, so theirSKIPIFblocks skip them and CI has been reporting green on 6 tests.Adding
make -C tests/data all(andrrdtoolto the apt list, which is what that Makefile shells out to) brings all 22 into the run. Two then fail, both stale expectations rather than regressions:rrd_016ends in a trailing%s, which needs at least one character and never gets one.rrd_017expects an extra trailing sample andend=920808300. librrd returnsend=920808000and 12 rows on 1.7.2 (Debian 13, Ubuntu 24.04) and on 1.11.0 (Homebrew) alike..gitignorepicks up the generated fixtures and the run-tests output so the suite stops dirtying the tree.Validation
phpize && ./configure --with-rrd && make && make -C tests/data all && make test, on php:8.4-cli with librrd 1.7.2 and on macOS with librrd 1.11.0: 22/22 pass,REPORT_EXIT_STATUS=1exits 0.Stack order. This is part of a series, each building on the one before. Merge order:
#11 (test suite) → #12 (memory safety) → #13 (open_basedir, value semantics) → #14 (php-src master) → #15 (librrd argv) → #16 (argument builder) → #17 (autoconf). Commits below this PR's own belong to the ones underneath it.