-
Notifications
You must be signed in to change notification settings - Fork 585
Do not report a private method overriding a private trait method as unused #6191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Jean-Beru
wants to merge
1
commit into
phpstan:2.2.x
Choose a base branch
from
Jean-Beru:fix-12201-private-method-overriding-trait
base: 2.2.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+91
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| <?php declare(strict_types = 1); | ||
|
|
||
| namespace Bug12201; | ||
|
|
||
| trait KernelTrait | ||
| { | ||
| /** | ||
| * @return string[] | ||
| */ | ||
| private function getAllowedEnvs(): array | ||
| { | ||
| return []; | ||
| } | ||
|
|
||
| /** | ||
| * @return string[] | ||
| */ | ||
| protected function getKernelParameters(): array | ||
| { | ||
| return $this->getAllowedEnvs(); | ||
| } | ||
| } | ||
|
|
||
| trait MicroKernelTrait | ||
| { | ||
| use KernelTrait; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| <?php declare(strict_types = 1); | ||
|
|
||
| namespace Bug12201; | ||
|
|
||
| // The traits live in bug-12201-traits.php which is not analysed on purpose: | ||
| // it stands for a dependency living outside of the analysed paths. | ||
| class AppKernel | ||
| { | ||
| use MicroKernelTrait; | ||
|
|
||
| /** | ||
| * @return list<string> | ||
| */ | ||
| private function getAllowedEnvs(): array | ||
| { | ||
| return ['prod', 'dev', 'test']; | ||
| } | ||
| } | ||
|
|
||
| class AnotherKernel | ||
| { | ||
| use MicroKernelTrait; | ||
|
|
||
| private function doNothing(): void | ||
| { | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why does
$method->isDeclaredInTrait()in line 63 not work?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see now, that we have 2 declared methods, and the one in the loop is not declared on the trait but overrides one from the trait