Conversation
VincentLanglet
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#15372
PHP 8.6 adds
ARRAY_FILTER_USE_VALUE(0) as an explicit$modeforarray_filter(). It is now part of the allowed constants for that parameter. The parameter takes a single value, so combining it with another mode is still reported asargument.bitmaskNotAllowed.While testing it, I noticed the result was not narrowed with this mode:
ArrayFilterFunctionReturnTypeHelper::determineMode()only recognised the values ofARRAY_FILTER_USE_KEYandARRAY_FILTER_USE_BOTH, soARRAY_FILTER_USE_VALUE(and a literal0) gavearray<int, int|null>where omitting the mode givesarray<int, int>. A value of0now maps to the default mode.The rule test runs with
phpVersion: 80600. The type inference test needs the constant at runtime, so it is gated with// lint >= 8.6.