Conversation
VincentLanglet
approved these changes
Oct 5, 2026
VincentLanglet
requested changes
Oct 5, 2026
| trait FooTrait | ||
| { | ||
| #[\Override] | ||
| const FROM_PARENT = 5; |
Contributor
There was a problem hiding this comment.
Parse error: tests/PHPStan/Rules/Constants/data/constant-override-attr.php:57
55| {
56| #[\Override]
> 57| const FROM_PARENT = 5;
58|
59| const PROTECTED_FROM_PARENT = 5;
Traits cannot have constants
I think you need // lint >= 8.2 rather than // lint >= 8.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#15370
PHP 8.6 allows
#[\Override]on class constants and enum cases (RFC). This follows what was done for properties in 8b85e62, 7f73847 and 64e9776:#[\Override]that overrides nothing is reported (classConstant.override,enum.caseOverride), regardless of the PHP version, like methods and properties. A private parent constant does not count, as the RFC says. The fix removes the attribute.#[\Override]is reported (classConstant.missingOverride,enum.caseMissingOverride) when the newcheckMissingOverrideConstantAttributeparameter is enabled. When it isnull(the default), it followscheckMissingOverrideMethodAttributeon PHP 8.6+, likecheckMissingOverridePropertyAttributedoes on PHP 8.5+. The fix adds the attribute. Constants declared in traits are skipped, as for properties.The shared logic lives in
OverrideAttributeOnConstantCheck, used byOverridingConstantRuleand a newOverridingEnumCaseRule(enum cases areEnumCasenodes, and their prototype can only come from an interface). Forconst A = 1, B = 2;the attribute applies to both constants, so no fix is offered there.The new parameter mirrors the property one. If you would rather reuse
checkMissingOverrideMethodAttributewithout a dedicated parameter, I'm happy to change it. I have not touched the documentation on the website.