docs(STRINGS-3095): Warn that job tags match all keys carrying the tag - #1257
Merged
Łukasz Ciesielski (lookasc) merged 1 commit intoSep 9, 2026
Merged
Conversation
Add a caution note to the create-job `tags` field so callers know a shared tag pulls in every key already carrying it, and to use `translation_key_ids` to scope to specific keys. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
API changelog (oasdiff)Doc-only edits (descriptions, examples) do not appear here. |
Łukasz Ciesielski (lookasc)
marked this pull request as ready for review
September 8, 2026 12:49
Łukasz Ciesielski (lookasc)
requested a review
from Mikko Karkee (Varpuspaavi)
September 8, 2026 12:53
Mikko Karkee (Varpuspaavi)
approved these changes
Sep 8, 2026
Łukasz Ciesielski (lookasc)
deleted the
docs/strings-3095-tags-collision-warning
branch
September 9, 2026 07:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related ticket: https://phrase.atlassian.net/browse/STRINGS-3095
Purpose
tagsfield was documented without warning that a shared tag matches every key already carrying it, which let a caller unintentionally pull dozens of unrelated pre-existing keys into a job.translation_key_idswhen they need to scope a job to specific keys.