fix(frontend): handle computed property names safely and prevent AST text panics - #29
Merged
Merged
Conversation
…text panics - Harden syntaxMemberName with panic recovery and support for string/numeric literal computed property expressions. - Replace unsafe member.Name().Text() calls with syntaxMemberName in type alias signatures, union type signatures, function parameter types, object literals, and destructuring patterns. - Add unit test TestCheckSupportsComputedPropertyNameInTypes in internal/typescriptgo/parse_test.go. - Add corpus test case computed_property_types.ts under internal/compiler/testdata/corpus/types/. - Update docs/typescript-parity-report.md with computed property name support.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR hardens AST member name extraction across the TypeScript frontend to safely handle computed property names and unknown AST nodes without panicking.
Changes
syntaxMemberNamehardening: Add panic recovery guard and handle string/numeric literal computed expressions (internal/typescriptgo/syntax_stmt_class.go)..Name().Text()calls: UsesyntaxMemberNameacrossTypeAliasDeclaration,UnionType, function parameter types, object literals, and destructuring patterns (syntax_stmt.go,syntax.go,syntax_expr.go,syntax_destruct.go).TestCheckSupportsComputedPropertyNameInTypesininternal/typescriptgo/parse_test.go.computed_property_types.tsunderinternal/compiler/testdata/corpus/types/.docs/typescript-parity-report.md.