feat(stdlib): 100% parity for node:tls, node:https, and node:timers - #31
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Achieves 100% core subset parity for
node:tls,node:https, andnode:timersagainst official Node.js v22 specifications with strict zero-workaround, zero-no-op compliance.Module Parity & Audit Metrics
node:tls: 51 / 51 official APIs (100.0%), 0 missing gapsnode:https: 17 / 17 official APIs (100.0%), 0 missing gapsnode:timers: 21 / 21 official APIs (100.0%), 0 missing gapsKey Implementations
node:tls:setDefaultCACertificatesoverloads and validation forstring[]andArrayBufferView[]inputs.node:https:https.Serverconfiguration and connection lifecycle methods:closeAllConnections(): thiscloseIdleConnections(): thissetTimeout(msecs?, callback?): thisheadersTimeout,requestTimeout,maxHeadersCount,maxRequestsPerSocket[Symbol.asyncDispose](): Promise<void>hostvshostnameand port parsing inparseUrlOptions.node:timers:ImmediatewithhasRef(),ref(),unref(),[Symbol.dispose]().Timeoutwithclose(),hasRef(),ref(),refresh(),unref(),[Symbol.toPrimitive](),[Symbol.dispose]().Schedulerwithwait(delay, options)andyield().promises.schedulerwithwaitandyield.clearTimeout,clearInterval, andclearImmediateto accept instances ofTimeoutandImmediateas well as primitive numeric IDs.Verification
go run ./cmd/parity -audit -filter tls,... -filter https,... -filter timers-> 100% PASS (0 gaps).NODE_BIN=... go run ./cmd/parity -filter api/tls.ts,... api/https.ts,... api/timers.ts-> 100% PASS.go test -count=1 ./...(all packages PASS).go test -count=1 ./internal/typescriptgo/...(PASS).go build ./cmd/scriptgo(PASS).docs/typescript-parity-report.mdtables.