Skip to content

Record the report-ownership fix in the 1.5.0 changelog #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luisleo526 merged 2 commits into from
Oct 9, 2026
Merged

Record the report-ownership fix in the 1.5.0 changelog #362

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7928a86
docs: record the native attempt-report fix under 1.5.0
luisleo526 Oct 9, 2026
0c055fc
docs: scope the batch report promise to engine pre-begin refusals
luisleo526 Oct 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ README's *Releases* section and on the GitHub releases page. From 1.0.0 the
version number follows semantic versioning over the surfaces the
[public contract](docs/pages/public-contract.md) lists.

## Unreleased
## 1.5.0 — Unreleased

- **Recorded outputs.** A module can record what it computes on each bar
besides its trades: doubles in named slots per bar, doubles kept once per
Expand All @@ -31,6 +31,25 @@ version number follows semantic versioning over the surfaces the
symbol are unchanged, and `PF_ABI_VERSION` stays 4. The new members enter
`engine_script_run_v19` without an epoch; a C++ object compiled against an
earlier v19 header is rebuilt with the library.
- **A run's report belongs to the call that began it ([#361]).** Once a call
reaches the engine, its batch report belongs to that call's attempt. A call
the engine refuses before it begins a run (a begin outside `Ready`, a refused
bar array or run option, a calendar or timezone refusal, a begin over a live
stream) now gets the empty report (every array `NULL`, every count 0) instead
of the rows the handle kept from an earlier call, and
`strategy_native_run_v1` answers it `PF_NATIVE_E_RUN_FAILED`, never
`PF_NATIVE_OK`; the reason stays in `strategy_get_last_error`. The C entry's
`PF_NATIVE_E_HANDLE` and `PF_NATIVE_E_ARGUMENT` checks, and native-module
argument preflight, still return before the engine runs and leave caller
output untouched. A run that began and then failed still publishes its
partial report, and `strategy_stream_fill_report`, the explicit stream
snapshot, still returns a live stream's rows, even after a batch call was
refused over the stream. The gate is the engine's own report reader,
`BacktestEngine::fill_report`, so the C and native-module entry points and
the generated `run_backtest` / `run_backtest_full` wrappers all obey it, with
no change to emitted source.

[#361]: https://github.com/pineforge-4pass/pineforge-engine/pull/361

## 1.4.0 — 2026-10-08

Expand Down
Loading