Repository navigation
docs: describe the reference data by what it is - #367
Draft
luisleo526 wants to merge 1 commit into
Draft
luisleo526 wants to merge 1 commit into
luisleo526 wants to merge 1 commit into
Conversation
Reword comments, docs and READMEs that described where the reference trade lists and bars came from. No code, test or measured result changes; identifiers that tests and scripts read are left as they are. The Pine v6 catalog steps from b1fbf0b now state only the result.
luisleo526
force-pushed
the
lv/engine-prose-wording
branch
from
October 11, 2026 04:48
258784b to
54e63fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This rewords comments, docs and READMEs that described where the reference trade lists and bars came from. They now describe the data by what it is. It changes no code, no test and no measured result.
What changed. 67 files: 42 Markdown files (fixture READMEs, docs, the root and benchmarks READMEs), 9 Python files and 16 C++ files (comments and docstrings only). Nothing under
src/orinclude/.How it was checked.
Open, and the unmarked one) are named consistently throughout.What this leaves, and why.
.gitignore,CMakeLists.txt, one source file and three scripts) lands with a separate change, because they fall outside the paths a text-only change may take without a full sweep.benchmarks/README.md:18still carries an older phrase. The provenance checker (benchmarks/check_provenance.py) matches that exact phrase, so the README line and the checker's pattern change together in one small follow-up change that adds a test showing the checker still rejects a false claim.benchmarks/results/selection.jsonandselection.mdare generated output. The strings that produce them, and the probe identifiers they carry, change in a later change together with a regeneration, not by hand.metrics.json,meta.jsonand the like) are not touched; they belong to separate changes.The diff view will show the removed lines, and they remain in history.