Skip to content

docs: name the run-failure catalog by its own name; move a test glob off the build path - #368

Merged
luisleo526 merged 4 commits into
mainfrom
lv/s5-public-wording
Oct 11, 2026
Merged

luisleo526 merged 4 commits into
mainfrom
lv/s5-public-wording

Conversation

@luisleo526

Copy link
Copy Markdown
Collaborator

What this changes

Comment, banner and docstring text only; no behaviour change.

  • include/pineforge/run_failure.hpp, scripts/check_run_failure_codes.py (the generator banner, the render_codes_header comment, and the module docstring at line 4), and the generated include/pineforge/run_failure_codes.hpp and src/run_failure_registry.inc, name the run-failure catalog by its own file name instead of by a directory path. The path the code actually opens is unchanged.
  • tutorial/run.py describes the release harness by its role rather than by a file path.
  • Six comment-only files ride this PR: .gitignore, CMakeLists.txt, scripts/run_strategy.py, scripts/symbol_calendar.py, scripts/verify_corpus.py, src/ta_extremes_volume.cpp.
  • The confirmed-capabilities file(GLOB ... refused_*.cpp) discovery moves into a new tests/confirmed_capabilities_refusals.cmake, included from runner/CMakeLists.txt at the same position, inside the same guard, with the same variable name, the same pattern and the same order.

What proves it

  • The five Python files are AST-identical to the base once docstrings are blanked.
  • The C/C++ files are identical after comments are stripped.
  • The two generated files render byte-identical at each revision, and the repository's own check prints 64 codes, registry in sync, 70 files scanned for uncoded throws, OK.
  • The six-file change is byte-identical to the reviewed patch, by sha256.
  • No build, test or configure ran on the reviewing host for these proofs; the full remote verification is the job below.

Remote verification

rj-20261011t061212-69b0c6 on this tree (520f75684, tree 235043d0): preflight, release, debug, sanitizers, kernel, docs - all six exit 0.

🤖 Generated with Claude Code

The run-failure header and the two comment strings in the catalog
generator named the catalog by its build-directory path; they now name
it as run_failure_codes.json. The generator was re-run and
include/pineforge/run_failure_codes.hpp and src/run_failure_registry.inc
carry the new banner; their diff is banner lines only. The tutorial's
run_error docstring describes the decision's owner by role instead of by
script name. No code path changes: the catalog is still opened at
docker/run_failure_codes.json.
Six comment-only files carried out of an earlier change so they do not
wait for it: .gitignore, CMakeLists.txt, scripts/run_strategy.py,
scripts/symbol_calendar.py, scripts/verify_corpus.py and
src/ta_extremes_volume.cpp. Each edit is a comment, a docstring or a
label; no statement, argument, path or default changes.
…ke file

The file(GLOB ...) that discovers the generated refused_*.cpp fixtures now
lives in tests/confirmed_capabilities_refusals.cmake and is included from
runner/CMakeLists.txt at the position it held before, inside the same
guard. Variable name, glob pattern and ordering are unchanged, so the same
sources register in the same order.
@luisleo526
luisleo526 marked this pull request as ready for review October 11, 2026 08:34
@luisleo526
luisleo526 merged commit 8d61433 into main Oct 11, 2026
22 checks passed
@luisleo526
luisleo526 deleted the lv/s5-public-wording branch October 11, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant