planner: fix the global binding is not working when using Prepared Statement with "select ... as col ... group by col"#69766
planner: fix the global binding is not working when using Prepared Statement with "select ... as col ... group by col"#69766qw4990 wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughPrepared statement plan cache entries now retain binding-matching context. Test-mode binding matching reuses an existing per-statement cache entry when no override is provided. ChangesPrepared statement binding
Estimated code review effort: 3 (Moderate) | ~20 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.12.2)level=error msg="Running error: context loading failed: failed to load packages: failed to load packages: failed to load with go/packages: context deadline exceeded" Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #69766 +/- ##
================================================
- Coverage 76.3192% 74.2886% -2.0307%
================================================
Files 2041 2051 +10
Lines 560139 575388 +15249
================================================
- Hits 427494 427448 -46
- Misses 131744 147692 +15948
+ Partials 901 248 -653
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
What problem does this PR solve?
Issue Number: close #57992
Problem Summary: planner: fix the global binding is not working when using Prepared Statement with "select ... as col ... group by col"
What changed and how does it work?
planner: fix the global binding is not working when using Prepared Statement with "select ... as col ... group by col"
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
Summary by CodeRabbit