style(web): fix inconsistencies in new settings layouts - #10177
Open
extoci wants to merge 3 commits into
Open
Conversation
Fix the extra project-row indent and rounded internal separators in grouped settings sections. Let the parent sections own row geometry across source control and connections. Codex, GPT-5.6-luna via T3 Code.
Contributor
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a small, localized settings-layout cleanup that changes only row spacing, indentation, corner rounding, and hover presentation across existing settings and onboarding lists. It introduces no new behavior, data changes, controls, or product-default changes. Notes:
You can add or adjust custom eligibility rules. Learn more. |
macroscopeapp
Bot
dismissed
their stale review
September 5, 2026 19:38
Dismissing prior approval to re-evaluate 2e683d8
This reverts commit 2e683d8.
macroscopeapp
Bot
dismissed
their stale review
September 5, 2026 19:48
Dismissing prior approval to re-evaluate 8d93ec0
Contributor
Author
|
note: i reverted this last change because i think codex just messed up lol |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix inconsistencies in settings:
(human written note: for some of the images in "before" i used max contrast to make it more visible, my agent did not when capturing after screenshots, this is not a regression)
Screenshots
Before (weird unnecessary left padding on Start form Origin):
After:
Before (rounded borders on non-edge items in Source Control & Remote Environments):
After:
Codex, GPT-6 via T3 Code, on behalf of Exotic.
Note
Remove rounded corners and responsive padding from settings row layouts
ITEM_ROW_CLASSNAMEin itemRows.tsGeneralSettingsPanelwithin SettingsPanels.tsxITEM_ROW_CLASSNAMEdocumentation to describe parent-owned borders and separatorsITEM_ROW_CLASSNAMEorENDPOINT_ROW_CLASSNAMEMacroscope summarized 8d93ec0.