perf(web): speed up folder menu sorting - #10190
Open
AksharP5 wants to merge 1 commit into
Open
Conversation
2 tasks
Contributor
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This small optimization reuses a lazily created collator while preserving the existing folder precedence and natural filename ordering. The accompanying test covers equivalent-name ordering, and no broader runtime capability or configuration behavior is introduced. You can add or adjust custom eligibility rules. Learn more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Folder breadcrumb menus repeat locale setup for each filename comparison. Reuse one lazily created collator per menu calculation, keeping the existing natural ordering and folder precedence.
Fixes #10191.
Why
On this repository's 169-entry
apps/web/srcfolder, the complete menu-list helper dropped from 1.39 ms to 0.20 ms. This is a warmed Node 26.8.1 benchmark on Linux, not measured UI latency. The output was identical.Verification
filePath.test.tstests pass, including natural ordering and stable ties across case and leading-zero variants.git diff --checkpass.Checklist
No visual or interaction changes.
Implemented and reviewed with GPT-6 through Codex.