feat(web): add machine tabs to project settings - #9754
Open
maria-rcks wants to merge 3 commits into
Open
Conversation
Contributor
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — The PR adds a machine-tab workflow to project settings and changes multi-checkout projects to open in an “All machines” scope by default. It also conditionally hides checkout-specific and destructive controls based on the selected tab, making this a meaningful user-facing product behavior change. You can add or adjust custom eligibility rules. Learn more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Project settings now open grouped projects on an All machines tab for shared values, with a tab per checkout for local grouping, actions, and removal controls. Machine tabs show only the machine name, and the redundant Project heading stays out of the multi-checkout layout.
Verified in the real app with two grouped checkouts; web typecheck, formatting, and targeted lint pass, while the focused existing Vitest suite remains blocked before collection by an undefined config access.
before
after
Built with
gpt-5.6-solin T3 Code.Note
Low Risk
UI-only scoping in project settings; checkout selection defaults to group-wide edits for multi-checkout groups instead of a single representative checkout.
Overview
Grouped projects with more than one checkout now use a horizontal All machines tab plus per-machine tabs instead of a checkout dropdown in the Checkout section.
All machines shows shared Project settings (name, icon, model, workspace, auto-pull) and Danger (remove everywhere). A machine tab shows Checkout details (path, grouping, actions, remove checkout). Single-checkout projects keep the previous layout with no tabs.
Machine tabs reuse provider-settings tab styling, show
EnvironmentMachineIconfrom each environment’s server config, and default selection to All machines (selectedCheckoutKeystarts asnull). User docs inproject-settings.mddescribe the new scope.Reviewed by Cursor Bugbot for commit e0f623b. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Replace checkout dropdown with machine tabs in
ProjectSettingsPanelMacroscope summarized e0f623b.