Skip to content

feat(web): add machine tabs to project settings - #9754

Open
maria-rcks wants to merge 3 commits into
pingdotgg:mainfrom
maria-rcks:t3code/clarify-project-machine-settings
Open

feat(web): add machine tabs to project settings#9754
maria-rcks wants to merge 3 commits into
pingdotgg:mainfrom
maria-rcks:t3code/clarify-project-machine-settings

Conversation

@maria-rcks

@maria-rcks maria-rcks commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

Project settings now open grouped projects on an All machines tab for shared values, with a tab per checkout for local grouping, actions, and removal controls. Machine tabs show only the machine name, and the redundant Project heading stays out of the multi-checkout layout.

Verified in the real app with two grouped checkouts; web typecheck, formatting, and targeted lint pass, while the focused existing Vitest suite remains blocked before collection by an undefined config access.

before

project settings before machine tabs

after

project settings with all-machines and checkout tabs

Built with gpt-5.6-sol in T3 Code.


Note

Low Risk
UI-only scoping in project settings; checkout selection defaults to group-wide edits for multi-checkout groups instead of a single representative checkout.

Overview
Grouped projects with more than one checkout now use a horizontal All machines tab plus per-machine tabs instead of a checkout dropdown in the Checkout section.

All machines shows shared Project settings (name, icon, model, workspace, auto-pull) and Danger (remove everywhere). A machine tab shows Checkout details (path, grouping, actions, remove checkout). Single-checkout projects keep the previous layout with no tabs.

Machine tabs reuse provider-settings tab styling, show EnvironmentMachineIcon from each environment’s server config, and default selection to All machines (selectedCheckoutKey starts as null). User docs in project-settings.md describe the new scope.

Reviewed by Cursor Bugbot for commit e0f623b. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Replace checkout dropdown with machine tabs in ProjectSettingsPanel

  • Replaces the checkout select control with a horizontally scrollable tab group in ProjectSettingsPanel.tsx, featuring an "All machines" scope and one tab per checkout.
  • Shared project settings display under "All machines", while checkout-specific settings display under individual machine tabs.
  • Updates project-settings.md to document the new scope behavior.
  • Behavioral Change: The previous checkout dropdown is no longer rendered, and the Danger section is now only visible under the "All machines" scope.

Macroscope summarized e0f623b.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Sep 4, 2026
Comment thread apps/web/src/components/settings/ProjectSettingsPanel.tsx
@macroscopeapp

macroscopeapp Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — The PR adds a machine-tab workflow to project settings and changes multi-checkout projects to open in an “All machines” scope by default. It also conditionally hides checkout-specific and destructive controls based on the selected tab, making this a meaningful user-facing product behavior change.

You can add or adjust custom eligibility rules. Learn more.

Comment thread apps/web/src/components/settings/ProjectSettingsPanel.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant