Skip to content

Rename and deprecated rfc8888 package - #351

Merged
mengelbart merged 1 commit into
mainfrom
fix/rfc8888-package-name
Sep 11, 2026
Merged

mengelbart merged 1 commit into
mainfrom
fix/rfc8888-package-name

Conversation

@mengelbart

Copy link
Copy Markdown
Contributor

Rename rfc8888 packages. We don't have any other packages named after the respective RFCs.

@codecov

codecov Bot commented Jul 31, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 7.69231% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.29%. Comparing base (a8ad680) to head (a3df37e).

Files with missing lines Patch % Lines
pkg/rfc8888/rfc8888.go 0.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #351      +/-   ##
==========================================
- Coverage   81.54%   81.29%   -0.26%     
==========================================
  Files          90       91       +1     
  Lines        4671     4683      +12     
==========================================
- Hits         3809     3807       -2     
- Misses        683      696      +13     
- Partials      179      180       +1     
Flag Coverage Δ
go 81.29% <7.69%> (-0.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mengelbart
mengelbart force-pushed the fix/rfc8888-package-name branch 2 times, most recently from 9d7c0ca to fa6661b Compare July 31, 2025 11:49
@mengelbart
mengelbart requested a review from JoTurk July 31, 2025 11:49
@mengelbart
mengelbart force-pushed the fix/rfc8888-package-name branch from fa6661b to 7f82d87 Compare September 10, 2025 09:06
@JoTurk

JoTurk commented Sep 11, 2026

Copy link
Copy Markdown
Member

I think we can ignore the API check this time, since interceptor is v0 and I think this change is compatible enough.

@mengelbart
mengelbart force-pushed the fix/rfc8888-package-name branch from 7f82d87 to a3df37e Compare September 11, 2026 07:30
@mengelbart

Copy link
Copy Markdown
Contributor Author

Sounds good, I'll merge it now. Sorry, I didn't merge it earlier. I kind of lost track of this.

@mengelbart
mengelbart merged commit b982a12 into main Sep 11, 2026
18 of 19 checks passed
@mengelbart
mengelbart deleted the fix/rfc8888-package-name branch September 11, 2026 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants