Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fully deleted Storage GC groups currently delete their empty output and return without retiring the old files. Repeated updates therefore leave obsolete files permanently REGULAR.
Retire these groups atomically without a replacement file. Journal their safe visibility-fold timestamp, confirm retirement only after a covering recovery checkpoint, protect pending journal files from physical cleanup, and restore the old catalog if the selected checkpoint predates retirement. Equal-invalidity candidates now prefer older file IDs so a bounded group limit does not repeatedly select newly created groups before older ones.
Validation:
mvn -pl pixels-retina -am -Dtest=TestStorageGcWal,TestEmptyStorageGc -Dsurefire.failIfNoSpecifiedTests=false test: 20 tests passed, none skipped.Closes #1415
Additional combined live validation after the separate sink same-key coalescing fix (pixelsdb/pixels-sink#22): HyBench SF100 original Proto replay ingested 22,945,933 rows and fully committed all 452,616 admitted transactions. Two GC cycles and three partial-live group rewrites completed. After draining, savingaccount/checkingaccount each had 30,200,000 active versions, customer 30,000,000 and company 200,000, exactly matching their initial populations; insert-growing tables are reported separately. Sink shutdown had no error entries. This is functional integration evidence, not a steady-state or isolated performance comparison. The repeated formal matrix has resumed. Results: gengdy1545/retina-graph#34.