Repository navigation
release: ship the manager's jump to source pane in helper 0.2.3; plugin 0.9.4 - #80
Merged
Merged
Conversation
Enter in the manager's active view focuses the Herdr pane the selected annotation was captured from and closes the manager. Herdr's CLI focuses a pane by id only through `herdr agent focus`, so agent panes are focused directly; for any other pane the manager asks `herdr pane get` for its tab and focuses that tab instead. An annotation with no pane id, or whose pane has closed, gets a status message and nothing is focused. The footer adds `↵ jump`, which fits the 98-column goldens without clipping, so the re-recorded screens change only in that line. refs #2
…in 0.9.4 Enter in the manager lives in rust/, and installs download the helper pinned by herdr-annotate.version. Bumping the helper to 0.2.3 lets a rust-lite-v0.2.3 release carry it, and the new pin makes existing installs fetch it. refs #2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enter in the manager's active view now focuses the Herdr pane the selected annotation was captured from, then closes the manager (#2).
Herdr's CLI focuses a pane by id only through
herdr agent focus, so agent panes are focused directly. For any other pane the manager reads the pane's tab withherdr pane getand focuses that tab. If the annotation has no pane id, or its pane has closed, the manager shows a status message and focuses nothing. Herdr cannot scroll a pane to a position, so the jump stops at the pane.The footer adds
↵ jump. It fits the 98-column goldens, so the re-recorded screens change only in that line. README and docs/lite-testing.md list the key.This bumps the helper to 0.2.3 and the plugin to 0.9.4 in all four manifests, the way #79 did. The
rust-lite-v0.2.3tag goes on this PR's head, and the release must publish before this merges.refs #2