Repository navigation
fix(last): count replies for pick, read agy's shell markers, match windows process names - #119
Merged
Merged
Conversation
…ndows process names - every host reader except codex counted prompts toward `n`, so a prompt still waiting for its reply took the only slot of `--pick 1`, and discovery chose a just-started conversation with no reply over the previous one. `n` now counts assistant replies, and discovery requires one (antigravity, claude ladder, pi, omp, command code); copilot, droid, hermes and opencode get the same counting. - `ANTIGRAVITY_AGENT` / `ANTIGRAVITY_CONVERSATION_ID` select the antigravity host, and the exported conversation id is read exactly, as `CODEX_THREAD_ID` is for codex. - herdr's process fallback matches `agy.exe` and `\`-separated paths, for every known agent and for the reported group leader. refs plannotator/herdr-annotate#70
This was referenced Oct 28, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups reported by @mfujita47 in plannotator/herdr-annotate#70 after 0.9.6.
1.
ncounted prompts. Every reader except Codex took the newestnmessages of either role, andlocate()filtered to assistant replies afterwards. So--pick 1returned only a waitingUSER_INPUTand failed with "has no assistant messages yet", and folder discovery picked a just-started conversation with only a prompt instead of the previous one. A sharedthrough_replieshelper now stops at thenth assistant reply (prompts newer than it are kept for context), and discovery requires a reply (has_reply). This applies to Antigravity, Claude Code (ladder and parser), pi / OMP / Command Code, Copilot, Droid, Hermes (dropped the SQLLIMIT, which counted prompts) and OpenCode v1/v2. Droid's selection is unchanged: it deliberately reads the newest log as is, matching Plannotator.2. agy shell markers.
detect_hostselects Antigravity onANTIGRAVITY_AGENTorANTIGRAVITY_CONVERSATION_ID, checked right afterCOPILOT_CLIand beforeGEMINI_CLI/OMPCODE. In fallback discovery, the exported conversation id goes through the exact resolver, the same wayCODEX_THREAD_IDdoes: an unknown id is an error and never falls back to the folder.ANTIGRAVITY_APP_DATA_DIRwas already honoured (#117).3. Windows process names.
known_hostand the group-leader fallback strip/or\directories and a case-insensitive.exesuffix, for every known agent.The Linux
/proc/<pid>/fdpresence-lock scan is not included. Herdr already reports the conversation id for agy panes, and in-shell runs now carry it. That leaves only Linux panes without a Herdr session id, and the scan would need agy-specific lock-file handling that we have not checked against a live agy.Tests: regression tests for each item (antigravity, claude, command code, hermes, opencode, pi, detect,
lastintegration, herdr launch).cargo fmt --check,cargo clippy --workspace --all-targets -D warnings,cargo test --workspace(416 passed).refs plannotator/herdr-annotate#70