Skip to content

update sdk - #138

Merged
erohinaelena merged 2 commits into
mainfrom
erohinaelena/update-sdk
Sep 25, 2026
Merged

erohinaelena merged 2 commits into
mainfrom
erohinaelena/update-sdk

Conversation

@erohinaelena

@erohinaelena erohinaelena commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 4/5

The PR should not merge until the SDK test dependency resolves without a developer-local tarball.

Fix All in Claude CodeFindings

  1. P1 Local tarball breaks clean installs ▶
Fix with agent prompt
### Issue 1
pnpm-lock.yaml:8758
On a fresh checkout without the sibling developer worktree, `@platforma-sdk/test` tries to resolve `@platforma-sdk/model` from `../../worktrees/platforma/fix-pl-ag-data-table-reload-loop/sdk/model/package.tgz`. That file is not part of this repository, so installing dependencies for the test and workflow packages fails before the workspace can build or test. The second test snapshot has the same reference; even where the tarball exists, its recorded model version is 1.83.17 rather than the catalog’s 1.84.1.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

The PR updates the shared SDK and graph-maker dependency versions, refreshes their lockfile graph, and adds patch release metadata. The lockfile also introduces an external tarball dependency that prevents a clean install.

  • Important touched terms: GraphMakerState is the graph editor’s persisted state type, and GraphMakerProps supplies graph configuration types such as chartType; their upstream @milaboratories/graph-maker package moves from 1.8.0 to 1.9.0, while their local uses are unchanged.
  • @platforma-sdk/model supplies shared model types and utilities; its catalog version moves from 1.83.17 to 1.84.1, but the test dependency snapshot instead references an external 1.83.17 tarball.
  • @platforma-sdk/workflow-tengo supplies the Tengo workflow integration; it moves from 6.10.1 to 6.12.1 alongside tengo-builder 4.0.27 to 4.1.4.
  • The Changeset declares patch releases for the block, model, and UI packages.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart LR
  C[pnpm catalog: SDK model 1.84.1] --> W[Workspace packages]
  T[SDK test 1.84.1] --> L[Lockfile model dependency]
  L --> F[External worktree tarball: model 1.83.17]
  F --> I[Clean install cannot resolve file]
Loading

Reviews (1) · Last reviewed commit: "update sdk"

Comment thread pnpm-lock.yaml Outdated
'@milaboratories/pl-client': 3.17.3
'@milaboratories/pl-middle-layer': 1.72.0(@bytecodealliance/preview2-shim@0.17.8)(@types/node@24.5.2)
'@milaboratories/pl-tree': 1.15.4
'@platforma-sdk/model': file:../../worktrees/platforma/fix-pl-ag-data-table-reload-loop/sdk/model/package.tgz

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Local tarball breaks clean installs

On a fresh checkout without the sibling developer worktree, @platforma-sdk/test tries to resolve @platforma-sdk/model from ../../worktrees/platforma/fix-pl-ag-data-table-reload-loop/sdk/model/package.tgz. That file is not part of this repository, so installing dependencies for the test and workflow packages fails before the workspace can build or test. The second test snapshot has the same reference; even where the tarball exists, its recorded model version is 1.83.17 rather than the catalog’s 1.84.1.

Knowledge Base Used: Build and release automation

Prompt To Fix With AI
This is a comment left during a code review.
Path: pnpm-lock.yaml
Line: 8758

Comment:
**Local tarball breaks clean installs**

On a fresh checkout without the sibling developer worktree, `@platforma-sdk/test` tries to resolve `@platforma-sdk/model` from `../../worktrees/platforma/fix-pl-ag-data-table-reload-loop/sdk/model/package.tgz`. That file is not part of this repository, so installing dependencies for the test and workflow packages fails before the workspace can build or test. The second test snapshot has the same reference; even where the tarball exists, its recorded model version is 1.83.17 rather than the catalog’s 1.84.1.

**Knowledge Base Used:** [Build and release automation](https://app.greptile.com/milaboratories/-/custom-context/knowledge-base/platforma-open/graph-maker/-/docs/build-and-release-automation.md)

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Fix in Claude Code

The committed lockfile pinned `@platforma-sdk/model` to
`file:../../worktrees/platforma/fix-pl-ag-data-table-reload-loop/sdk/model/package.tgz`
-- a path outside this repository, in a local developer worktree. Five entries
carried it, including both `@platforma-sdk/test` snapshots, so a fresh checkout
without that worktree failed to install the test and workflow packages before
anything could build or run.

It also held the model at 1.83.17 while the catalog asked for 1.84.1, so even a
machine that happened to have the tarball resolved a different version from the
one the workspace declares.

Reinstalled from the registry: model and ui-vue 1.84.1, graph-maker 1.9.0, with
the stale transitive duplicates that pin had dragged in dropped. `pnpm install
--frozen-lockfile` is satisfied and `pnpm check` passes on all 11 tasks.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@erohinaelena
erohinaelena added this pull request to the merge queue Sep 25, 2026
Merged via the queue into main with commit 25db4bc Sep 25, 2026
37 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant