MILAB-6950: update SDK - #26
AStaroverov wants to merge 1 commit into
Conversation
| "@milaboratories/helpers": 1.14.5 | ||
| "@platforma-sdk/tengo-builder": 4.0.26 | ||
| "@platforma-sdk/package-builder": 3.15.0 | ||
| "@platforma-sdk/tengo-builder": 4.1.4 |
There was a problem hiding this comment.
Saved grid state lacks coverage
This upgrade is meant to stop PlAgDataTableV2 from repeatedly rebuilding when it receives saved grid state, but there is no regression test for that case. The implemented block test covers only empty inputs. A future SDK change could bring back the loop or lose saved column settings without the tests catching it. Please add a test that reopens a block with populated tableState and checks that the grid settles with its settings intact.
Prompt To Fix With AI
This is a comment left during a code review.
Path: pnpm-workspace.yaml
Line: 21
Comment:
**Saved grid state lacks coverage**
This upgrade is meant to stop `PlAgDataTableV2` from repeatedly rebuilding when it receives saved grid state, but there is no regression test for that case. The implemented block test covers only empty inputs. A future SDK change could bring back the loop or lose saved column settings without the tests catching it. Please add a test that reopens a block with populated `tableState` and checks that the grid settles with its settings intact.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
There was a problem hiding this comment.
The fix and its regression coverage live in the SDK, not in this block. @platforma-sdk/ui-vue tests the stored-state comparison in sdk/ui-vue/src/components/PlAgDataTable/sources/grid-state.test.ts and mounts PlAgDataTableV2 through a reload in sdk/ui-vue/src/components/PlAgDataTable/__tests__/PlAgDataTableV2.reload.jsdomtest.ts. This PR only bumps the dependency; a block-level test would duplicate that coverage and needs a mounted AG Grid, which the block test setup does not provide. Not adding one here.
There was a problem hiding this comment.
That’s a valid distinction. Since the behavior change and its regression tests are owned by @platforma-sdk/ui-vue, and this PR only consumes the released SDK version, adding a block-level AG Grid test here would duplicate SDK coverage and isn’t practical with the current block test setup. I’m withdrawing this finding; no additional test is required in this PR.
Tip: You can customize Greptile's behavior for this repo with .greptile/rules.md and .greptile/config.json.
Bumps the SDK catalog to the current npm latest (
pnpm update-sdk), mainly to pick up@platforma-sdk/ui-vue1.84.2.That release fixes
PlAgDataTableV2rebuilding its AG Grid endlessly (~20 times a second) when the page has a saved grid state — most often right after a block rebuild. The loop strobed the column headers and flooded the console with AG Grid licence banners. The reload comparison now filters the stored state down to the columns the grid actually has and compares only the fields that state expresses, so it converges.Changes:
pnpm-workspace.yaml: SDK catalog entries → npm latestpnpm-lock.yaml: regeneratedVerified locally:
pnpm install+pnpm build:dev-no-softwarepass.The PR appears safe to merge, with a non-blocking gap in regression coverage for its saved-grid-state fix.
Fix with agent prompt
Summary
The PR updates the SDK catalog and lockfile, principally bringing in the
ui-vuerelease intended to fix repeated grid rebuilding, and adds a patch changeset.PlAgDataTableV2is the UI’s data-grid component; its SDK version changes from 1.83.3 to 1.84.2 to address rebuilding with saved state.PlDataTableStateV2is the persisted table configuration bound to that component; its local usage is unchanged, but the upgraded grid consumes it.propertiesTableis the model output supplying the grid’s columns and data; its SDK model dependency changes from 1.83.0 to 1.84.1.workflow-tengosupplies Tengo workflow facilities; its catalog version changes from 6.8.3 to 6.12.1.Diagram
%%{init: {'theme': 'neutral'}}%% flowchart LR W["pnpm-workspace.yaml: SDK catalog"] --> L["pnpm-lock.yaml: resolved packages"] L --> M["@platforma-sdk/model"] L --> U["@platforma-sdk/ui-vue"] M --> P["propertiesTable and persisted tableState"] P --> G["PlAgDataTableV2"] U --> GReviews (1) · Last reviewed commit: "MILAB-6950: update SDK"