Add mobile packages to manifest - #12
Draft
cehan-Chloe wants to merge 1 commit into
Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12 +/- ##
==========================================
+ Coverage 33.61% 35.88% +2.27%
==========================================
Files 27 27
Lines 1889 1956 +67
Branches 140 159 +19
==========================================
+ Hits 635 702 +67
Misses 1252 1252
Partials 2 2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Type (required)
Indicate the type of change your pull request is:
patchminormajorExtends xlr compile's manifest with packages.ios/packages.android — the package info (name + version) that provides a plugin's capabilities on each mobile platform — alongside the packages.react field already shipped in this branch including both bazel and npm cases.
Bazel
getPackages() reads XLR_IOS_PACKAGE_NAME/XLR_ANDROID_PACKAGE_NAME env vars, the same pattern XLR_PACKAGE_NAME already uses for react. All three platforms share the one Bazel stamp (STABLE_VERSION) — there's no separate per-platform version to plumb through.
Need to work together with player-ui/rules_player#121
Non-Bazel
There's no build graph to read a mobile identity from outside Bazel — ios/android publish from separate repos on their own release cadence. So they come from a new, optional config.xlr.platformPackages map in the project config, keyed by npm package name:
A plugin absent from the map just gets react only (not an error — not every plugin has a mobile counterpart). An entry present but missing name or version for a platform is dropped, with a warning naming the exact field and platform (e.g. No "version" for "ios" of "@my-org/my-plugin" in config.xlr.platformPackages).
Test result
Verified end-to-end against the nppm repo