Expose staff chat and isolate module resources#102
Merged
Conversation
Taahh
marked this pull request as ready for review
July 22, 2026 00:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StaffChatMessageEventfor toggled and command-based staff chatPlexPlayerView.staffChat()PlexModule.getResource()prefer resources from the module JAR itselfWhy
Modules currently cannot reliably observe staff chat: toggled staff messages are cancelled internally, direct
/adminchat <message>calls emit no chat event, and the public player view does not expose staff-chat mode. This adds supported integration points without requiring modules to depend on Plex server internals.Module resource loading also delegated to Plex first. A module requesting a common path such as
config.ymlcould therefore receive Plex’s own bundled file. Resource lookup now searches the module URL classloader directly, and the existing migration-specific workaround is consolidated into the public resource method.The new player-view method has a default implementation to preserve compatibility for third-party
PlexPlayerViewimplementations. Redis-received staff messages intentionally do not fire the local-origin event.Validation
./gradlew :api:javadoc :server:compileJava./gradlew clean buildwith a bundledconfig.ymlgit diff --check