Fix module-owned resource lookup#103
Draft
Taahh wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PlexModule.getResource()search the requesting module JAR before Plex’s parent classloaderPlexModule.getResource()Why
Plex module classloaders delegate to Plex first. When a module requests a common resource such as
config.yml, the lookup can return Plex’s own bundled configuration instead of the file inside the module JAR. This prevents modules from safely using conventional resource names.Impact
Modules can bundle and load a normal
config.ymlwithout colliding with Plex resources. Existing module migration behavior remains child-first, now through the shared public API.Validation
./gradlew :api:javadoc :server:compileJava./gradlew clean buildwithconfig.ymlpackaged in its JARgit diff --check