Conversation
Build the JS string with json.dumps instead of a template literal, so a
backtick or a ${...} sequence in the URL is compared as plain text.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #316
_check_document_readyput the URL into a JS template literal unescaped, so a backtick raised aSyntaxErrorthatcreate_and_waitcounted as a load, and a${...}sequence ran in the page. The URL now goes throughjson.dumps, as suggested in the issue, and a new test covers both cases. I left theexceptionDetailscheck from the issue notes out of this PR and can add it here or in a follow-up, whichever you prefer. This touches the same lines as #295, so whichever lands second will need a small rebase.