Repository navigation
fix: handle None return from error handler in no-output background callbacks #4012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
T4rk1n
merged 11 commits into
plotly:dev
from
dajiaohuang:fix/3628-background-callback-error-handler
Oct 26, 2026
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
cce590e
fix: handle None return from error handler in no-output background ca…
dajiaohuang ad21a5b
Merge branch 'dev' into fix/3628-background-callback-error-handler
dajiaohuang 38bd0e7
fix: pass output_spec to MCP background task handler
dajiaohuang f267f58
style: format callback error handling
dajiaohuang c0be071
style: match pinned Black formatting
dajiaohuang 054249f
test: cover no-output background callback errors
dajiaohuang ebf5f95
test: assert no-output callback error handling
dajiaohuang fc7f061
fix: apply output_spec guard to cancel branch and simplify tests
dajiaohuang 47cd995
Merge remote-tracking branch 'origin/dev' into fix/3628-background-ca…
dajiaohuang f5cde05
Fix MCP task results for no-output background callbacks
dajiaohuang d092ea0
Merge branch 'dev' into fix/3628-background-callback-error-handler
T4rk1n File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| from tests.background_callback.utils import setup_background_callback_app | ||
|
|
||
|
|
||
| def test_lcbc019_background_callback_on_error_without_output(dash_duo, manager): | ||
| with setup_background_callback_app(manager, "app_bg_on_error") as app: | ||
| dash_duo.start_server(app) | ||
|
|
||
| dash_duo.find_element("#start-no-output-cb-onerror").click() | ||
| dash_duo.wait_for_contains_text( | ||
| "#no-output-cb-onerror-output", | ||
| "callback: An error occurred inside a background callback: no output callback error", | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.