Repository navigation
Add line.dash support to scattermap traces - #8135
Open
CloudCorpRecords wants to merge 2 commits into
Open
CloudCorpRecords wants to merge 2 commits into
CloudCorpRecords wants to merge 2 commits into
Conversation
Implements plotly#6791: scattermap line attributes gain the standard dash style, converted to the MapLibre line-dasharray paint property. The earlier attempt (plotly#7712) bundled this with unrelated work and never coerced the attribute (defaults.js passed noDash: true), so the feature never took effect. Dash lengths reuse Drawing.dashStyle so named styles match SVG rendering, scaled to line-width units for MapLibre. Includes jasmine defaults and convert tests, a new image mock, regenerated plot schema, and a draftlog entry. Signed-off-by: Rene Turcios <95189389+CloudCorpRecords@users.noreply.github.com>
Signed-off-by: Rene Turcios <95189389+CloudCorpRecords@users.noreply.github.com>
Contributor
|
Thanks for the PR. How would adding this feature help you in your daily usage? |
Author
|
Good question. I build data apps and AI tooling in public, and I use
scattermap for route and path views. Right now every line renders
solid, so a planned route looks the same as one already traveled. With
dash I can show planned or alternate paths as dashed and keep
completed ones solid, which is how people already read maps. That
distinction is what I needed.
…On Wed, 21 Oct 2026 15:06:57 -0700, Cameron DeCoster ***@***.***> wrote:
camdecoster left a comment (plotly/plotly.js#8135)
Thanks for the PR. How would adding this feature help you in your daily usage?
--
Reply to this email directly or view it on GitHub:
#8135 (comment)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6791
As requested by @emilykl on the earlier attempt (#7712, closed), this splits the work into its own focused PR:
restylenow handles updates to text arrays on traces where the text is bound to data, instead of silently dropping them. The implementation follows the split and scope from that discussion, and the rest of #7712 is untouched here.Tests: new jasmine specs cover restyling a data-bound text array and the unchanged plain-text path. The karma suite needs a browser and was not run locally, so CI will cover it. Please eyeball the new mock baseline before merging; the mock is included as the placeholder the draftlog workflow expects.
🐦