Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue
Closes #4353
Description of change
Plotly.js error bars have a
colorproperty but noopacity, sopx.scatter(..., color=..., opacity=0.6, error_y=...)faded the markers and left the error bars fully opaque.For categorically colored traces (one marker color per trace), this now copies that color onto
error_x/error_y/error_zas anrgba(...)string that includes the requested opacity.Continuous color still cannot follow per-point marker colors:
error_y.coloris a single color in the schema, not an array. That path is unchanged and covered so opacity no longer has to special-case it.Demo
Testing strategy
Added unit tests in
tests/test_optional/test_px/test_px.pyfor categoricalerror_y+ opacity, categoricalerror_x+ opacity, the no-opacity inheritance path, and continuous color + opacity.Guidelines