Skip to content

doc: fix two dead links in the PCA and violin pages - #5885

Closed
farisbasha wants to merge 1 commit into
plotly:doc-prodfrom
farisbasha:doc-fix-dead-links
Closed

farisbasha wants to merge 1 commit into
plotly:doc-prodfrom
farisbasha:doc-fix-dead-links

Conversation

@farisbasha

Copy link
Copy Markdown

Link to issue

No issue. This is a small docs link fix.

Description of change

Fixes two dead links in the published docs (this PR targets doc-prod):

  • doc/python/ml-pca.md: the "Diabetes" link pointed at scikit-learn.org/stable/datasets/index.html#diabetes-dataset, which returns 404. The section is now on datasets/toy_dataset.html#diabetes-dataset.
  • doc/python/violin.md: the "previously known as Joy Plot" link pointed at serialmentor.com/blog/2017/9/15/goodbye-joyplots, which returns 404. The post is now at clauswilke.com/blog/2017/09/15/goodbye-joyplots/.

Demo

N/A (link targets only).

Testing strategy

No code changed. I checked with curl that both old URLs return 404, both new ones return 200, and the #diabetes-dataset anchor exists on the new scikit-learn page.

Guidelines

- ml-pca.md: scikit-learn moved the Diabetes dataset section from
  datasets/index.html to datasets/toy_dataset.html.
- violin.md: the "Goodbye joyplots" post moved from serialmentor.com to
  clauswilke.com.

Both old URLs return 404.
@camdecoster

Copy link
Copy Markdown
Contributor

Hi! Thanks for the pull request. To help us deal with the increased volume of contributions we’re receiving, can you answer two questions about this work?

  1. What’s your interest in making this change? Is it impacting your use of this library, and if so can you show us a concrete example? Or are you simply eager to improve the library for everyone else?
  2. How involved were AI agents in this work? In particular, if this is primarily AI-driven work (which is fine, we use it too), it can be more efficient for us to simply take over the PR and hand it to our agents than to spend the time writing out comments.

We spend significant human effort reviewing each PR, so we really appreciate your help figuring out the best way to move this one toward merging. Thanks!

@farisbasha

Copy link
Copy Markdown
Author

Thanks for asking, happy to help.

  1. It isn't blocking my own use of plotly. I'm trying to help improve the docs for everyone; the links in this PR return 404 for readers today.
  2. This is primarily AI-driven work: an AI assistant found the dead links, checked the old and new URLs with curl, and prepared the change. So feel free to take it over or redo it with your agents if that's easier for you, no problem at all.

@camdecoster

Copy link
Copy Markdown
Contributor

We like to replace URLs ourselves. As such, could you please create an issue for this (and reference this PR)? We'll be able to make the update in the future. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants