Repository navigation
Conversation
Contributor
|
Thanks for the PR, but this has already been resolved by #5478. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue
Closes #5405
Description of change
Load the Natural Earth populated-places ZIP directly instead of using the
GeoPandas example-catalog path that has been deprecated and removed.
Demo
No visual-design change. The example still renders the same world map with
Natural Earth city markers.
Testing strategy
I ran the updated code block with GeoPandas 1.2.0 and Plotly 7.1.0. It loaded
243 point geometries, preserved the
namecolumn forhover_name, andproduced one
scatter_geotrace.git diff --checkpasses.Additional information
The direct Natural Earth ZIP URL follows the approach recommended in
the earlier GeoPandas example discussion.
This is a documentation-only change, so no changelog entry is needed.
Guidelines
confirm that this PR follows them.
documentation PR).