Skip to content

fix: avoid ZMQ slow-joiner loss on pipeline connect #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chrisk314 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: avoid ZMQ slow-joiner loss on pipeline connect #297

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion plugboard/connector/zmq_channel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,9 @@ async def connect_recv(self) -> ZMQChannel:
self._recv_channel = ZMQChannel(
recv_socket=recv_socket, topic=self._topic, maxsize=self._maxsize
)
await asyncio.sleep(0.1) # Ensure connections established before first send. Better way?
# Allow extra time for the proxy subprocess's SUB socket subscription to propagate
# to XPUB before the sender starts publishing (ZMQ "slow joiner" problem).
await asyncio.sleep(0.5)
return self._recv_channel


Expand Down
1 change: 1 addition & 0 deletions tests/integration/test_process_with_components_run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ def tempfile_path() -> _t.Generator[Path, None, None]:


@pytest.mark.asyncio
@pytest.mark.flaky(reruns=3) # Flaky on Github Actions with Ray + ZMQ proxy (slow joiner)
@pytest.mark.parametrize(
"process_cls, connector_cls",
[
Expand Down
Loading