Skip to content

fix(TreeCascadeDropdownQuestion): fix incorrect options displayed in custom dropdown#32

Merged
Rom1-B merged 3 commits into
pluginsGLPI:mainfrom
MyvTsv:ticket44958
Jul 3, 2026
Merged

fix(TreeCascadeDropdownQuestion): fix incorrect options displayed in custom dropdown#32
Rom1-B merged 3 commits into
pluginsGLPI:mainfrom
MyvTsv:ticket44958

Conversation

@MyvTsv

@MyvTsv MyvTsv commented Jun 29, 2026

Copy link
Copy Markdown
Contributor
  • I have performed a self-review of my code.
  • I have added tests (when available) that prove my fix is effective or that my feature works.
  • I have updated the CHANGELOG with a short functional description of the fix or new feature.
  • This change requires a documentation update.

Description

  • It fixes !44958
  • TreeCascadeDropdown questions that used a custom dropdown menu were displaying incorrect values. Since all values for custom dropdown menus are stored in the same “glpi_dropdowns_dropdowns” table, the query returned all values instead of filtering based on the itemtype of the selected custom dropdown menu item.

Screenshots (if appropriate):

Before:
image

After:
image

@MyvTsv MyvTsv self-assigned this Jun 29, 2026
@MyvTsv MyvTsv marked this pull request as ready for review June 29, 2026 14:38
@MyvTsv MyvTsv requested review from Rom1-B and stonebuzz June 29, 2026 14:38
Comment thread tests/Model/QuestionType/TreeCascadeDropdownQuestionTest.php
Comment thread src/Controller/TreeDropdownChildrenController.php
Comment thread CHANGELOG.md
Comment thread tests/Model/QuestionType/TreeCascadeDropdownQuestionTest.php
Comment thread tests/Model/QuestionType/TreeCascadeDropdownQuestionTest.php
@stonebuzz stonebuzz requested a review from Rom1-B July 1, 2026 12:30
MyvTsv and others added 3 commits July 2, 2026 16:18
Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com>
@Rom1-B Rom1-B merged commit ccabeaf into pluginsGLPI:main Jul 3, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants