Fix: restore GLPI 11 install and CI checks

CHANGELOG.md

@@ -0,0 +1,16 @@
+# Change Log
+
+All notable changes to this project will be documented in this file.
+
+The format is based on [Keep a Changelog](http://keepachangelog.com/) and this project adheres to [Semantic Versioning](http://semver.org/).
+
+## [Unreleased]
+
+### Fixed
+
+- Fix plugin installation failing on raw queries executed through `DBmysql::request()`
+- Fix fatal error caused by missing `bool` return types on computer group rights methods
+- Fix plugin uninstallation failing and leaving package tables and display preferences behind
+- Fix PHP 8.4 deprecation on implicitly nullable parameters
+- Replace deprecated `Html::displayErrorAndDie()` and `Html::displayRightError()` calls with HTTP exceptions
+- CI: fix PHPStan bootstrap for GLPI 11, migrate ESLint configuration to flat config, drop the stray `glpi-project/tools` composer dependency, declare a unique composer autoloader suffix

composer.json

@@ -3,14 +3,14 @@
         "php": ">=8.1"
     },
     "require-dev": {
-        "glpi-project/tools": "^0.8.4",
         "php-parallel-lint/php-parallel-lint": "^1.4",
         "phpstan/extension-installer": "^1.4",
         "phpstan/phpstan": "^1.10",
         "phpstan/phpstan-deprecation-rules": "^1.1",
         "squizlabs/php_codesniffer": "^4.0"
     },
     "config": {
+        "autoloader-suffix": "PluginDeploy",
         "optimize-autoloader": true,
         "platform": {
             "php": "8.1"

eslint.config.mjs

@@ -0,0 +1,22 @@
+import glpiEslintConfig from '../../eslint.config.mjs';
+
+const filteredConfig = glpiEslintConfig.filter(config => !config.ignores);
+
+export default [
+    ...filteredConfig,
+    {
+        ignores: [
+            'lib/*',
+            'node_modules/*',
+            'vendor/*',
+        ],
+    },
+    {
+        languageOptions: {
+            globals: {
+                GLPI_PLUGINS_PATH: true,
+                noUiSlider: true,
+            },
+        },
+    },
+];

front/package.php

@@ -30,6 +30,7 @@
 
 namespace GlpiPlugin\Deploy;
 
+use Glpi\Exception\Http\AccessDeniedHttpException;
 use Html;
 use Search;
 use Session;
@@ -38,6 +39,10 @@
 
 Session::checkRight("dashboard", UPDATE);
 
+if (!Package::canView()) {
+    throw new AccessDeniedHttpException();
+}
+
 Html::header(
     Package::getTypeName(Session::getPluralNumber()),
     '',
@@ -46,11 +51,6 @@
     'package'
 );
 
-$package = new Package();
-if ($package->canView()) {
-    Search::show('GlpiPlugin\Deploy\Package');
-} else {
-    Html::displayRightError();
-}
+Search::show('GlpiPlugin\Deploy\Package');
 
 Html::footer();

hook.php

@@ -32,13 +32,12 @@
 use GlpiPlugin\Deploy\Computer\GroupDynamic;
 use GlpiPlugin\Deploy\Computer\GroupStatic;
 use GlpiPlugin\Deploy\Package;
-use GlpiPlugin\Deploy\PackageJob;
 use GlpiPlugin\Deploy\PackageAction;
 use GlpiPlugin\Deploy\PackageCheck;
 use GlpiPlugin\Deploy\PackageFile;
+use GlpiPlugin\Deploy\PackageJob;
 use GlpiPlugin\Deploy\PackageTarget;
 use GlpiPlugin\Deploy\Profile;
-use GlpiPlugin\Deploy\PackageTimeslot;
 use GlpiPlugin\Deploy\Repository;
 use GlpiPlugin\Deploy\Timeslot;
 use GlpiPlugin\Deploy\TimeslotRange;
@@ -71,7 +70,7 @@
  * -------------------------------------------------------------------------
  */
 
- // Define Dropdown tables to be manage in GLPI :
+// Define Dropdown tables to be manage in GLPI :
 function plugin_deploy_getDropdown()
 {
     $dropdowns = [Timeslot::class => Timeslot::getTypeName(2)];
@@ -103,16 +102,18 @@ function plugin_deploy_install()
 /**
  * Plugin uninstall process
  *
- * @return boolean
+ * @return bool
  */
 function plugin_deploy_uninstall()
 {
     $migration = new Migration(PLUGIN_DEPLOY_VERSION);
 
+    PackageAction::uninstall($migration);
+    PackageCheck::uninstall($migration);
+    PackageFile::uninstall($migration);
     PackageTarget::uninstall($migration);
     Package::uninstall($migration);
     PackageJob::uninstall($migration);
-    PackageTarget::uninstall($migration);
     Profile::uninstall($migration);
     Repository::uninstall($migration);
     Group::uninstall($migration);