Skip to content

Ticket 44833#470

Merged
stonebuzz merged 2 commits into
pluginsGLPI:10.0/bugfixesfrom
TarekRemo:ticket_44833
Jul 3, 2026
Merged

Ticket 44833#470
stonebuzz merged 2 commits into
pluginsGLPI:10.0/bugfixesfrom
TarekRemo:ticket_44833

Conversation

@TarekRemo

Copy link
Copy Markdown

Checklist before requesting a review

Please delete options that are not relevant.

  • I have performed a self-review of my code.
  • I have added tests (when available) that prove my fix is effective or that my feature works.
  • I have updated the CHANGELOG with a short functional description of the fix or new feature.
  • This change requires a documentation update.

Description

  • It fixes !44833
  • The "Ticket status after an escalation" option was being applied when a ticket was created with an assigned group. This happened because processAfterAddGroup() (the item_add hook on Group_Ticket) always forced the ticket status without checking whether the group assignment occurred during ticket creation. In contrast, the sibling method addHistoryOnAddGroup() already skips it during ticket creation for this exact reason.
  • This behavior is incorrect because assigning a group while creating a ticket should not be considered an escalation. Therefore, the "Ticket status after an escalation" option should not be applied in this case.
  • Fix: processAfterAddGroup() now checks whether the current call originates from CommonITILObject::add() before applying the option, just as addHistoryOnAddGroup() already does. For consistency, this check has been extracted into a shared helper method, isRunningDuringItilCreation(), which is now used by both methods.

@TarekRemo TarekRemo self-assigned this Jul 1, 2026
@TarekRemo TarekRemo requested review from Rom1-B and stonebuzz July 1, 2026 09:20

@stonebuzz stonebuzz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@stonebuzz

Copy link
Copy Markdown
Contributor

can you validate with customers ?

@TarekRemo

Copy link
Copy Markdown
Author

can you validate with customers ?

customer approved the fix.

@stonebuzz stonebuzz merged commit 32982e3 into pluginsGLPI:10.0/bugfixes Jul 3, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants