Skip to content

Fix massive action modal not showing for more than 10 associated groups#473

Open
TarekRemo wants to merge 2 commits into
pluginsGLPI:mainfrom
TarekRemo:ticket_45027
Open

Fix massive action modal not showing for more than 10 associated groups#473
TarekRemo wants to merge 2 commits into
pluginsGLPI:mainfrom
TarekRemo:ticket_45027

Conversation

@TarekRemo

Copy link
Copy Markdown

Checklist before requesting a review

Please delete options that are not relevant.

  • I have performed a self-review of my code.
  • I have updated the CHANGELOG with a short functional description of the fix or new feature.
  • This change requires a documentation update.

Description

  • It fixes !45027
  • In the Escalation tab of a group's form, the massive action modal failed to open once the group was linked to more than 10 groups.
  • This was due to manageGroup() setting ontop => false on the massive action params when $nb > 10. However, Html::showMassiveActions() only creates the modal window when ontop is true (or forcecreate is set), while the "Actions" button is always rendered. As a result, for 11+ groups the button pointed to a modal object that was never created, so clicking it did nothing.
  • Fix: Removed the if ($nb > 10) { $massiveactionparams['ontop'] = false; } block.

@TarekRemo TarekRemo self-assigned this Jul 3, 2026
@TarekRemo TarekRemo added the bug label Jul 3, 2026
@TarekRemo TarekRemo requested review from Rom1-B and stonebuzz July 3, 2026 08:07
@TarekRemo

Copy link
Copy Markdown
Author

phpstan error doesn't come from these changes. Should I fix in this PR anyway ?

@stonebuzz

Copy link
Copy Markdown
Contributor

phpstan error doesn't come from these changes. Should I fix in this PR anyway ?

Yes please =)

@TarekRemo

Copy link
Copy Markdown
Author

phpstan error doesn't come from these changes. Should I fix in this PR anyway ?

Yes please =)

Removed the entire block because it's dead code since it's fully subsumed by the one just before it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants