Fix massive action modal not showing for more than 10 associated groups#473
Open
TarekRemo wants to merge 2 commits into
Open
Fix massive action modal not showing for more than 10 associated groups#473TarekRemo wants to merge 2 commits into
TarekRemo wants to merge 2 commits into
Conversation
Author
|
phpstan error doesn't come from these changes. Should I fix in this PR anyway ? |
Contributor
Yes please =) |
stonebuzz
approved these changes
Jul 3, 2026
Author
Removed the entire block because it's dead code since it's fully subsumed by the one just before it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
manageGroup()settingontop => falseon the massive action params when$nb > 10. However,Html::showMassiveActions()only creates the modal window whenontopis true (orforcecreateis set), while the "Actions" button is always rendered. As a result, for 11+ groups the button pointed to a modal object that was never created, so clicking it did nothing.if ($nb > 10) { $massiveactionparams['ontop'] = false; }block.