Feature/glpi 12.0 - #10
Open
Lainow wants to merge 6 commits into
Open
Conversation
jdurand-teclib
left a comment
jdurand-teclib
left a comment
There was a problem hiding this comment.
Apart from my comment (which is really minor and not really important), looks good to me
|
|
||
| ## [unreleased] | ||
|
|
||
| - GLPI 12 Compatibility No newline at end of file |
There was a problem hiding this comment.
Not much of a change, but changelog is missing the end of file empty line.
Suggested change
| - GLPI 12 Compatibility | |
| - GLPI 12 Compatibility | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.