Skip to content

Add/consumable mass action link associated items #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Herafia wants to merge 4 commits into
base: main
Choose a base branch
from
+16 −2
Open

Add/consumable mass action link associated items #592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
53dc0c4
Consumables : mass action link associated items
Herafia Jul 2, 2026
5677a60
CHANGELOG
Herafia Jul 2, 2026
cc3c621
phpSTAN
Herafia Jul 2, 2026
e4a6988
fix
Herafia Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/)
and this project adheres to [Semantic Versioning](http://semver.org/).

## [UNRELEASED]

### Added
- Add grouped actions to link consumables and related items

## [2.12.8] - 2026-06-24

### Added
Expand Down
12 changes: 11 additions & 1 deletion inc/link.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -633,7 +633,17 @@ public static function processMassiveActionsForOneItemtype(
break;

case 'createLink':
if (count($ids) > 1) {
// For consumables and cartridges, createLinkWithItem creates a new item
// (glpi_consumables/glpi_cartridges) for each selected detail line;
// therefore, multiple items can be linked to the same reference item at once
$first_item_data = reset($ma->POST['add_items']);
$allow_multiple_link = is_array($first_item_data) && in_array(
$first_item_data['itemtype'] ?? '',
['ConsumableItem', 'CartridgeItem'],
Comment on lines +636 to +642

@Rom1-B Rom1-B Jul 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reset() returns the first entry in add_items, so $allow_multiple_link is determined by one item's itemtype. An order can mix types (e.g., one Computer line and one ConsumableItem line). If the first entry happens to be a consumable, the guard passes and all selected lines — including non-consumable ones — are processed, linking multiple non-consumable order lines to the same asset. The original restriction was intended to prevent exactly that.

Suggested change
// For consumables and cartridges, createLinkWithItem creates a new item
// (glpi_consumables/glpi_cartridges) for each selected detail line;
// therefore, multiple items can be linked to the same reference item at once
$first_item_data = reset($ma->POST['add_items']);
$allow_multiple_link = is_array($first_item_data) && in_array(
$first_item_data['itemtype'] ?? '',
['ConsumableItem', 'CartridgeItem'],
// For consumables and cartridges, createLinkWithItem creates a new item
// (glpi_consumables/glpi_cartridges) for each selected detail line;
// therefore, multiple items can be linked to the same reference item at once
$allow_multiple_link = !empty($ma->POST['add_items']) && array_reduce(
$ma->POST['add_items'],
fn($carry, $data) => $carry && in_array(
$data['itemtype'] ?? '',
['ConsumableItem', 'CartridgeItem'],
true,
),

@stonebuzz stonebuzz Jul 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well seen

true,
);

if (!$allow_multiple_link && count($ids) > 1) {
$ma->addMessage(__s("Cannot link several items to one detail line", "order"));
foreach ($ids as $id) {
$ma->itemDone($item->getType(), $id, MassiveAction::ACTION_KO);
Expand Down
1 change: 0 additions & 1 deletion inc/order.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1825,7 +1825,6 @@ public function generateOrder($params)
$this->getFromDB($ID);

if (file_exists(PLUGIN_ORDER_TEMPLATE_CUSTOM_DIR . "custom.php")) {
// @phpstan-ignore-next-line: custom.php is not a file or it does not exist.
include_once(PLUGIN_ORDER_TEMPLATE_CUSTOM_DIR . "custom.php");
}

Expand Down