Repository navigation
Conversation
…ive SDK and advance the implementation reference to e24
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
purpshell
force-pushed
the
codex/mr-c-v2-credential-shapes
branch
from
October 17, 2026 19:14
ebf274b to
a7ced2c
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 3 draft. Do not merge or publish. Prepare TypeScript and Go/Python/PHP/Rust/C# organization/project validators for variable-length signed v2 credentials and reject v1 shapes. Validation checks framing only; the API authenticates signatures, purpose, context and live issuance records. Client tokens remain opaque with their existing prefix checks.
Stack dependency: native SDK PR #348 at
0822c934f25e0a8fa70ae4a799344ccb54f215bbis unmerged. This draft is stacked on that source and must wait for it. MR-C changes are the commits after that baseline; use that compare when reviewing. API codec contract: polymorfa/polymorfa#63847d34d0a1fe29579611b3296ca61ab2bd5eefcf9. API cutover: polymorfa/polymorfa#647, also held draft.Impact table
16596a61373afbf1a96054e9b923c0bdb1dcbc73delegates validation to this SDK. Its accepted published SDK pin must move with the cutover; no guessed unpublished version.docs/mr-c-v2-credentials.mdupdated; matching customer/API documentation is in the API draft.No impact table
Verification
GOWORK=off go test -p 2 ./...passes, including shared golden and v1 rejection. Native example-host race tests pass.cargo test --locked --jobs 2).No registry publication, live authenticated API acceptance, deployment, secret mounting or production use has been exercised. This draft is not a release-ready claim.
Session provenance
Codex gpt-6.1-sol in T3. Work is isolated under
~/.polymorfa-agent-work/mr-c/; original user worktrees preserved. The app thread ID is unavailable for transcript capture; no browser screenshot is claimed for a framing-only SDK change.Latest CI is not green: Go 1.25 failed the unchanged media-upload deadline
assertion at
packages/go/media_upload_test.go:299(invalid-upload-locationclassification instead of timeout). The pinned native baseline passed 20 focused
Go 1.25.14 race runs locally; this does not establish the CI failure's cause.
Go 1.24, both Python and PHP jobs pass; Rust matrix jobs are still running.
The Calls setup scripts now delegate server-key validation to the SDK, with a
new rejection/golden test included in CI. No review or re-review was requested.