Repository navigation
Propagate caller interruptions to ggsql inner queries - #18
Merged
Merged
Conversation
Forward the outer context interrupt flag while the sibling connection is active, check cancellation between SQL calls and Arrow batches, and restore DuckDB interruption errors after releasing the Rust result buffer. Join the forwarder before destroying its connection. Add embedded regression coverage for both entry points, repeated cancellation and connection reuse, single- and multi-threaded execution, and unrelated connection isolation. Run the Python tests against the distribution artifact in CI.
Contributor
Author
|
@thomasp85 any chance you could take a look at this PR? hoping to use this extension in the future, especially with DuckDB 2.0. |
#Conflicts: # src/ggsql_exec.cpp
The v1.5.6 format tooling joins single-element braced lists onto one line; apply to examples added on main since this branch diverged.
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward the outer context interrupt flag while the sibling connection is active, check cancellation between SQL calls and Arrow batches, and restore DuckDB interruption errors after releasing the Rust result buffer. Join the forwarder before destroying its connection.
Add embedded regression coverage for both entry points, repeated cancellation and connection reuse, single- and multi-threaded execution, and unrelated connection isolation. Run the Python tests against the distribution artifact in CI.