Add channel-transport transport OpenFOAM#551
Conversation
MakisH
left a comment
There was a problem hiding this comment.
Besides the fact that solver and config are in the same directory, it looks good overall. I have not yet tried to run it.
|
@fsimonis this seems to be close to merging. Does this need more work from your side, or just a new review iteration? edit: Actually, no. There is still a blocking modeling issue. |
|
Just finished a co-working session with @fsimonis. I pushed some new commits, which make the custom solver work with dynamic meshes and adjusts the case to apply dynamic mesh refinement with The settings are in Run with: The next step would be to further understand and adjust the mesh refinement settings. The coupled case currently fails, but this is expected since the adapter does not yet support remeshing (precice/openfoam-adapter#382). I can start an implementation of that. The accumulation of divSchemes
{
default none;
- div(phi,T) Gauss linearUpwind grad(T);
+ div(phi,T) Gauss linear grad(T);
}However, the numerics and the boundary conditions are the same as in the pitzDaily case, so this might be unrelated. I would look next if the changes from the standard Some URLs for reference: |
|
I got the non-AMR version running. I moved the AMR specific changes to #689 and will revert this PR to the non-AMR version. |
b1f4d6a to
44e2384
Compare
|
@MakisH I think I implemented all suggestions. Could you review again? |
MakisH
left a comment
There was a problem hiding this comment.
I applied a few more changes directly, and in terms of usability and integration to the rest of the tutorials, the case is ready. It still needs reference results for the system tests (I can add them).
I still have doubts about the outlet conditions and the space integration of T. But I am also still confused.
|
I tried setting |
|
Thank you, @Fujikawas! I can confirm that this scheme works just fine. Here is what I get with the coarse mesh and channel-transport-openfoam-bounded-gauss-upwind.mp4I will then use this scheme, the coarse mesh, the simpler |
co-authored-by: June <94080048+Fujikawas@users.noreply.github.com>
|
Such a simple solution and we spent hours debugging this 😂 Having the simpler mesh is actually better as it makes the base of the AMR version more realistic. @MakisH feel free to merge |
This PR adds an OpenFOAM variant of the transport participant of the channel-transport tutorial.
The case uses a modified version of the scalarTransportFoam application. Main difference is that we assume$\phi$ every timestep.
Uto change every timestep. Therefore we need to recompute@MakisH Can you give this PR a thorough review to make it as easy to use as possible?
Result:
Screencast_20251210_145936.webm
Checklist:
changelog-entries/<PRnumber>.md.edit: updated to the working state