Conversation
Choose the parser for `style` blocks from the `type` attribute instead of always using `css`. `scss` and `less` types use their prettier parsers, and unsupported types such as `sass` are left unformatted. Closes prettier#532 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Shinigami92
added
the
type: enhancement
Contributor
Coverage Report
File Coverage |
Shinigami92
reviewed
Sep 29, 2026
| const typeRaw: string | boolean = typeAttrToken.val; | ||
| // If it's not a string, best not do anything | ||
| if (typeof typeRaw !== 'string') { | ||
| return; |
Member
There was a problem hiding this comment.
issue (if-minor): line 35 and 42 are both uncovered, do you think we can add test cases for them?
Author
There was a problem hiding this comment.
Should be all set. Let me know what you think!
Member
There was a problem hiding this comment.
I'm a bit confused myself, but the Coverage Report -> File Coverage -> src/utils/script-mime-types.ts now shows 42, 49 👀
Author
There was a problem hiding this comment.
No idea. I think those lines have coverage. I'll investigate more tomorrow. Thanks!
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Choose the parser for
styleblocks from thetypeattribute instead of always usingcss.scssandlesstypes use their prettier parsers, and unsupported types such assassare left unformatted instead of failing with a CssSyntaxError.Closes #532