Skip to content

test: close file handles in failure mocks - #41

Merged
danyel117 merged 1 commit into
mainfrom
fix/bun-1.4-filehandle-tests
Sep 3, 2026
Merged

test: close file handles in failure mocks#41
danyel117 merged 1 commit into
mainfrom
fix/bun-1.4-filehandle-tests

Conversation

@danyel117

Copy link
Copy Markdown
Contributor

Summary

  • close the real temporary-file handle even when a test override simulates a close failure
  • preserve the simulated error and existing operation-order assertions
  • unblock the Publish workflow under Bun 1.4.0, which now treats GC-closed FileHandles as errors

Verification

  • Bun 1.4.0 full suite: 213 passing, 0 failures, 0 errors
  • Bun 1.3.8 atomic-write suite: 29 passing
  • bun run lint
  • bun run typecheck
  • bun run build
  • bun run pack:dry-run
  • Claude Opus review: APPROVE

@danyel117
danyel117 merged commit 95df754 into main Sep 3, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant