fix: pause compatibility commands before admission - #45
Merged
Conversation
danyel117
commented
Sep 4, 2026
danyel117
left a comment
Contributor
Author
There was a problem hiding this comment.
Claude Opus independent review: APPROVE.
No merge-blocking findings. Opus verified the V2 SessionPrompt mutability contract, complete attachment sanitization, full-template ownership check, idempotence with native command executors, lifecycle/race guards, Plan-mode resume behavior, register_command: false, disposal, regression quality, 231 tests, lint, typecheck, package contents, and byte-for-byte reproducibility of dist/server.js.
Residual risks are non-blocking: template-format coupling to beta-18593 and a pre-existing narrow close-vs-pause TOCTOU shared by all pause paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/pause_goalat the V2 prompt-admission boundary when OpenCode executes the V1-compatible static command definition instead of the V2 command executor/pause_goaland/resume_goalpromptsReproduction
After installing
0.1.43, an OpenCode V2 standalone smoke showed/pause_goalcallingget_goalwhile the goal was stillactive; it only became paused after the model calledupdate_goal_status. With this change loaded fromdist/server.js, the model context already observes the paused goal and no active-stateget_goaloccurs.Verification
bun run lintbun run typecheckbun test(231 passing)bun run buildbun run pack:dry-runv0.0.0-beta-18593standalone smoke with isolated goal stateFollow-up to #36 and #44.
AI assistance: diagnosed from an end-to-end smoke, implemented, and reviewed with OpenCode agents; an independent Claude Opus review will be attached before merge.