chore(Link): remove unnecessary data-hover-color attribute#8211
chore(Link): remove unnecessary data-hover-color attribute#8211francinelucca wants to merge 4 commits into
data-hover-color attribute#8211Conversation
🦋 Changeset detectedLatest commit: 9201a7a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
There was a problem hiding this comment.
Pull request overview
Removes the data-hover-color attribute from the Link component’s rendered output, reverting a previously introduced DOM attribute that is no longer needed.
Changes:
- Removes
data-hover-color={hoverColor}from the renderedLinkelement.
Show a summary per file
| File | Description |
|---|---|
| packages/react/src/Link/Link.tsx | Stops rendering the data-hover-color attribute on Link. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Low
|
🤖 Lint issues have been automatically fixed and committed to this PR. |
1 similar comment
|
🤖 Lint issues have been automatically fixed and committed to this PR. |
|
Integration test results from github/github-ui PR:
All checks passed! |
Removing as per #5319 (comment)
Also added request for prop removal in next major here https://github.com/github/primer/issues/5430#issuecomment-5039700246
Changelog
Removed
data-hover-colorattribute in LinkRollout strategy
Testing & Reviewing