Skip to content

chore(Link): remove unnecessary data-hover-color attribute#8211

Open
francinelucca wants to merge 4 commits into
mainfrom
chore/remove-unnecessary-prop
Open

chore(Link): remove unnecessary data-hover-color attribute#8211
francinelucca wants to merge 4 commits into
mainfrom
chore/remove-unnecessary-prop

Conversation

@francinelucca

@francinelucca francinelucca commented Jul 21, 2026

Copy link
Copy Markdown
Member

Removing as per #5319 (comment)

Also added request for prop removal in next major here https://github.com/github/primer/issues/5430#issuecomment-5039700246

Changelog

Removed

  • unneeded data-hover-color attribute in Link

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Copilot AI review requested due to automatic review settings July 21, 2026 22:23
@francinelucca
francinelucca requested a review from a team as a code owner July 21, 2026 22:23
@francinelucca
francinelucca requested a review from TylerJDev July 21, 2026 22:23
@changeset-bot

changeset-bot Bot commented Jul 21, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 9201a7a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added the staff Author is a staff member label Jul 21, 2026
@github-actions github-actions Bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jul 21, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Action required

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the data-hover-color attribute from the Link component’s rendered output, reverting a previously introduced DOM attribute that is no longer needed.

Changes:

  • Removes data-hover-color={hoverColor} from the rendered Link element.
Show a summary per file
File Description
packages/react/src/Link/Link.tsx Stops rendering the data-hover-color attribute on Link.

Review details

  • Files reviewed: 2/2 changed files
  • Comments generated: 1
  • Review effort level: Low

Comment thread packages/react/src/Link/Link.tsx
@github-actions
github-actions Bot requested a deployment to storybook-preview-8211 July 21, 2026 22:29 Abandoned
@github-actions
github-actions Bot requested a deployment to storybook-preview-8211 July 21, 2026 22:35 Abandoned
@primer

primer Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

🤖 Lint issues have been automatically fixed and committed to this PR.

1 similar comment
@primer

primer Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

🤖 Lint issues have been automatically fixed and committed to this PR.

@primer-integration

Copy link
Copy Markdown

Integration test results from github/github-ui PR:

Passed  CI   Passed
Passed  VRT   Passed
Passed  Projects   Passed

All checks passed!

@francinelucca
francinelucca enabled auto-merge July 21, 2026 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants