Stop primo add from duplicating the Default group - #49
Merged
Merged
Conversation
After the first import server.yaml holds the server's id for Default, but a hand-authored site.yaml still saying group: default made add append a second Default entry, which was then rewritten to the same id: two identical groups, and a rewrite notice on every dev start. Point the site at the existing Default group instead, and drop repeated group ids whenever server.yaml is written so existing workspaces heal. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 6 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
A round-3 agent opened a site's preview URL, got the CMS, and couldn't tell it needed a preview build first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Round-3 release testing reproduced #17 from round 1:
server.yamlends up with the same "Default" group twice (same id, index 0 and 1).Cause
After the first import,
server.yamlholds the server's id for Default instead of thedefaultslug. A hand-authoredsite.yamlwithgroup: defaultmadeprimo addappend{ id: default, name: Default }, and the group writeback then rewrote that entry to the server's id, producing two identical entries.primo devalso printed a rewrite notice on every start.Fix
primo addreuses an existing group named Default and points the site at its id.write_server_configkeeps one entry per group id and re-indexes, so workspaces that already have the duplicate heal the next time the file is written.Tests
group: default→ add → dev. Before: two entries. After: one, with both sites on the same group id.write_server_configdedupe test. 94 tests: 93 pass, and the one skip needs a real binary.🤖 Generated with Claude Code