Skip to content
This repository was archived by the owner on Oct 23, 2018. It is now read-only.

[WIP] Adds minimal boilerplate#72

Open
DevanB wants to merge 4 commits into
masterfrom
minimal-example
Open

[WIP] Adds minimal boilerplate#72
DevanB wants to merge 4 commits into
masterfrom
minimal-example

Conversation

@DevanB

@DevanB DevanB commented Jan 7, 2018

Copy link
Copy Markdown
Collaborator

Please test to verify all is working!

@DevanB DevanB requested a review from marktani January 7, 2018 16:42

@marktani marktani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running the app results in errors

Unhandled (in react-apollo:Apollo(Home)) Error: Network error: Network request failed

@DevanB

DevanB commented Jan 13, 2018

Copy link
Copy Markdown
Collaborator Author

@marktani

This error is nasty and really should be handled in a more graceful way, but is being debated over in the react-apollo ticket (#604)

In the meantime, it seems you didn't have the server running.

This leads me to propose that we make sure the start script starts up possibly nodemon to start up the Expo packager and the server.

Thoughts?

@marktani

Copy link
Copy Markdown
Contributor

I definitely had the server running, but I can't say if I started the app first. Is that a problem?

@DevanB

DevanB commented Jan 13, 2018 via email

Copy link
Copy Markdown
Collaborator Author

@marktani

marktani commented Jan 13, 2018

Copy link
Copy Markdown
Contributor

Thanks I'll try that again 🙂

For the record, I am using a real Android device, if that makes a difference.

@DevanB

DevanB commented Jan 13, 2018 via email

Copy link
Copy Markdown
Collaborator Author

@DevanB

DevanB commented Feb 7, 2018

Copy link
Copy Markdown
Collaborator Author

Hmm, updated the Expo and the server locally tonight, and am seeing the same problem again. I now know that the problem is a network error, but haven't tracked down why the ApolloClient can't talk with the server when they are both running...

@DevanB DevanB changed the title Adds minimal boilerplate. [WIP] Adds minimal boilerplate Feb 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Development

Successfully merging this pull request may close these issues.

2 participants